Some minor changes

[phpeclipse.git] / net.sourceforge.phpeclipse / src / net / sourceforge / phpdt / internal / compiler / ast / Else.java

diff --git a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/Else.java b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/Else.java
index 302d650..47748bc 100644 (file)
--- a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/Else.java
+++ b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/Else.java
@@ -1,6 +1,5 @@
 package net.sourceforge.phpdt.internal.compiler.ast;
 
-import java.util.ArrayList;
 import java.util.List;
 
 /**
@@ -8,10 +7,10 @@ import java.util.List;
  * it's else
  * @author Matthieu Casanova
  */
-public class Else extends Statement {
+public final class Else extends Statement {
 
   /** the statements. */
-  public Statement[] statements;
+  private final Statement[] statements;
 
   /**
    * An else statement bad version ( : endif).
@@ -36,8 +35,8 @@ public class Else extends Statement {
               final int sourceStart,
               final int sourceEnd) {
     super(sourceStart, sourceEnd);
-    this.statements = new Statement[1];
-    this.statements[0] = statement;
+    statements = new Statement[1];
+    statements[0] = statement;
   }
 
   /**
@@ -58,37 +57,34 @@ public class Else extends Statement {
 
   /**
    * Get the variables from outside (parameters, globals ...)
-   * @return the variables from outside
+   *
+   * @param list the list where we will put variables
    */
-  public List getOutsideVariable() {
-    final ArrayList list = new ArrayList();
+  public void getOutsideVariable(final List list) {
     for (int i = 0; i < statements.length; i++) {
-      list.addAll(statements[i].getOutsideVariable());
+      statements[i].getOutsideVariable(list);
     }
-    return list;
   }
 
   /**
    * get the modified variables.
-   * @return the variables from outside
+   *
+   * @param list the list where we will put variables
    */
-  public List getModifiedVariable() {
-    final ArrayList list = new ArrayList();
+  public void getModifiedVariable(final List list) {
     for (int i = 0; i < statements.length; i++) {
-      list.addAll(statements[i].getModifiedVariable());
+      statements[i].getModifiedVariable(list);
     }
-    return list;
   }
 
   /**
    * Get the variables used.
-   * @return the variables from outside
+   *
+   * @param list the list where we will put variables
    */
-  public List getUsedVariable() {
-    final ArrayList list = new ArrayList();
+  public void getUsedVariable(final List list) {
     for (int i = 0; i < statements.length; i++) {
-      list.addAll(statements[i].getUsedVariable());
+      statements[i].getUsedVariable(list);
     }
-    return list;
   }
 }