The methods to get variables do not instantiate ArrayList each time, only one is...

[phpeclipse.git] / net.sourceforge.phpeclipse / src / net / sourceforge / phpdt / internal / compiler / ast / GlobalStatement.java

diff --git a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/GlobalStatement.java b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/GlobalStatement.java
index af63ccb..57c483e 100644 (file)
--- a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/GlobalStatement.java
+++ b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/GlobalStatement.java
@@ -2,11 +2,16 @@ package net.sourceforge.phpdt.internal.compiler.ast;
 
 import net.sourceforge.phpdt.internal.compiler.parser.Outlineable;
 import net.sourceforge.phpdt.internal.ui.PHPUiImages;
+import net.sourceforge.phpeclipse.PHPeclipsePlugin;
 import org.eclipse.jface.resource.ImageDescriptor;
 import org.eclipse.jface.text.Position;
+import org.eclipse.core.runtime.CoreException;
 
 import java.util.List;
 import java.util.ArrayList;
+import java.util.Arrays;
+
+import test.PHPParserSuperclass;
 
 /**
  * A GlobalStatement statement in php.
@@ -64,29 +69,43 @@ public class GlobalStatement extends Statement implements Outlineable {
 
   /**
    * Get the variables from outside (parameters, globals ...)
-   * @return the variables from outside
    */
-  public List getOutsideVariable() {
-    final ArrayList list = new ArrayList(variables.length);
+  public void getOutsideVariable(final List list) {
     for (int i = 0; i < variables.length; i++) {
-      list.addAll(variables[i].getUsedVariable());
+      variables[i].getUsedVariable(list);
     }
-    return list;
   }
 
   /**
    * get the modified variables.
-   * @return the variables modified
    */
-  public List getModifiedVariable() {
-    return new ArrayList(1);
+  public void getModifiedVariable(final List list) {
   }
 
   /**
    * Get the variables used.
-   * @return the variables used
    */
-  public List getUsedVariable() {
-    return new ArrayList(1);
+  public void getUsedVariable(final List list) {
+  }
+
+  /**
+   * We will analyse the code.
+   * if we have in globals a special variable it will be reported as a warning.
+   * @see Variable#SPECIAL_VARS
+   */
+  public void analyzeCode() {
+    for (int i = 0; i < variables.length; i++) {
+      if (arrayContains(Variable.SPECIAL_VARS, variables[i].getName())) {
+        try {
+          PHPParserSuperclass.setMarker("warning, you shouldn't request " + variables[i].getName() + " as global",
+                                        variables[i].sourceStart,
+                                        variables[i].sourceEnd,
+                                        PHPParserSuperclass.WARNING,
+                                        "");
+        } catch (CoreException e) {
+          PHPeclipsePlugin.log(e);
+        }
+      }
+    }
   }
 }