Some minor changes

[phpeclipse.git] / net.sourceforge.phpeclipse / src / net / sourceforge / phpdt / internal / compiler / ast / AstNode.java

diff --git a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/AstNode.java b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/AstNode.java
index e7ed112..4d3aec2 100644 (file)
--- a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/AstNode.java
+++ b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/AstNode.java
@@ -12,11 +12,11 @@ public abstract class AstNode {
   public int sourceStart, sourceEnd;
 
   /**
-   * Create a node giving starting and ending offset
+   * Create a node giving starting and ending offset.
    * @param sourceStart starting offset
    * @param sourceEnd ending offset
    */
-  public AstNode(final int sourceStart, final int sourceEnd) {
+  protected AstNode(final int sourceStart, final int sourceEnd) {
     this.sourceStart = sourceStart;
     this.sourceEnd = sourceEnd;
   }
@@ -52,16 +52,19 @@ public abstract class AstNode {
 
   /**
    * Get the variables from outside (parameters, globals ...)
+   * @param list the list where we will put variables
    */
   public abstract void getOutsideVariable(List list);
 
   /**
    * get the modified variables.
+   * @param list the list where we will put variables
    */
   public abstract void getModifiedVariable(List list);
 
   /**
    * Get the variables used.
+   * @param list the list where we will put variables
    */
   public abstract void getUsedVariable(List list);
 
@@ -69,16 +72,15 @@ public abstract class AstNode {
    * This method will analyze the code.
    * by default it will do nothing
    */
-  public void analyzeCode() {
-  }
+  public void analyzeCode() {}
 
   /**
-   * Check if the array array contains the object o
+   * Check if the array array contains the object o.
    * @param array an array
    * @param o an obejct
    * @return true if the array contained the object o
    */
-  public boolean arrayContains(Object[] array, Object o) {
+  public final boolean arrayContains(final Object[] array, final Object o) {
     for (int i = 0; i < array.length; i++) {
       if (array[i].equals(o)) {
         return true;