Some minor changes

[phpeclipse.git] / net.sourceforge.phpeclipse / src / net / sourceforge / phpdt / internal / compiler / ast / Define.java

diff --git a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/Define.java b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/Define.java
index 9669c82..7351341 100644 (file)
--- a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/Define.java
+++ b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/Define.java
@@ -1,25 +1,26 @@
 package net.sourceforge.phpdt.internal.compiler.ast;
 
-import java.util.List;
-
 import net.sourceforge.phpdt.internal.compiler.ast.declarations.VariableUsage;
 import net.sourceforge.phpdt.internal.compiler.parser.Outlineable;
 import net.sourceforge.phpdt.internal.ui.PHPUiImages;
-
 import org.eclipse.jface.resource.ImageDescriptor;
 import org.eclipse.jface.text.Position;
 
+import java.util.List;
+
 /**
  * a Define.
  * define(expression,expression)
+ * 
  * @author Matthieu Casanova
  */
-public class Define extends Statement implements Outlineable {
+public final class Define extends Statement implements Outlineable {
 
-  public Expression defineName,defineValue;
+  private final Expression defineName;
+  private final Expression defineValue;
 
-  private Object parent;
-  private Position position;
+  private final Object parent;
+  private final Position position;
 
   public Define(final Object parent,
                 final Expression defineName,
@@ -34,19 +35,25 @@ public class Define extends Statement implements Outlineable {
   }
 
   public String toString(final int tab) {
-    final StringBuffer buff = new StringBuffer(tabString(tab));
+    final String nameString = defineName.toStringExpression();
+    final String valueString = defineValue.toStringExpression();
+    final StringBuffer buff = new StringBuffer(tab + 10 + nameString.length() + valueString.length());
+    buff.append(tabString(tab));
     buff.append("define(");
-    buff.append(defineName.toStringExpression());
+    buff.append(nameString);
     buff.append(", ");
-    buff.append(defineValue.toStringExpression());
+    buff.append(valueString);
     buff.append(")");
     return buff.toString();
   }
 
   public String toString() {
-    final StringBuffer buff = new StringBuffer(defineName.toStringExpression());
+    final String nameString = defineName.toStringExpression();
+    final String valueString = defineValue.toStringExpression();
+    final StringBuffer buff = new StringBuffer(nameString.length() + valueString.length() + 3);
+    buff.append(nameString);
     buff.append(" = ");
-    buff.append(defineValue.toStringExpression());
+    buff.append(valueString);
     return buff.toString();
   }
 
@@ -64,20 +71,24 @@ public class Define extends Statement implements Outlineable {
 
   /**
    * Get the variables from outside (parameters, globals ...)
+   *
+   * @param list the list where we will put variables
    */
   public void getOutsideVariable(final List list) {
-    list.add(new VariableUsage(defineName.toStringExpression(),sourceStart));//todo: someday : evaluate the defineName
+    list.add(new VariableUsage(defineName.toStringExpression(), sourceStart));//todo: someday : evaluate the defineName
   }
 
   /**
    * get the modified variables.
+   *
+   * @param list the list where we will put variables
    */
-  public void getModifiedVariable(final List list) {
-  }
+  public void getModifiedVariable(final List list) {}
 
   /**
    * Get the variables used.
+   *
+   * @param list the list where we will put variables
    */
-  public void getUsedVariable(final List list) {
-  }
+  public void getUsedVariable(final List list) {}
 }