The methods to get variables do not instantiate ArrayList each time, only one is...

[phpeclipse.git] / net.sourceforge.phpeclipse / src / net / sourceforge / phpdt / internal / compiler / ast / ForeachStatement.java

diff --git a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/ForeachStatement.java b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/ForeachStatement.java
index 827c2aa..4f05ab4 100644 (file)
--- a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/ForeachStatement.java
+++ b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/ForeachStatement.java
@@ -42,36 +42,27 @@ public class ForeachStatement extends Statement {
 
   /**
    * Get the variables from outside (parameters, globals ...)
-   * @return the variables from outside
    */
-  public List getOutsideVariable() {
-    final ArrayList list = new ArrayList();
-    list.addAll(expression.getOutsideVariable());
-    list.addAll(variable.getOutsideVariable());
-    list.addAll(statement.getOutsideVariable());
-    return list;
+  public void getOutsideVariable(final List list) {
+    expression.getOutsideVariable(list);
+    variable.getOutsideVariable(list);
+    statement.getOutsideVariable(list);
   }
 
   /**
    * get the modified variables.
-   * @return the variables from we change value
    */
-  public List getModifiedVariable() {
-    final ArrayList list = new ArrayList();
-    list.addAll(expression.getModifiedVariable());
-    list.addAll(variable.getModifiedVariable());
-    list.addAll(statement.getModifiedVariable());
-    return list;
+  public void getModifiedVariable(final List list) {
+    expression.getModifiedVariable(list);
+    variable.getUsedVariable(list);
+    statement.getModifiedVariable(list);
   }
 
   /**
    * Get the variables used.
-   * @return the variables used
    */
-  public List getUsedVariable() {
-    final ArrayList list = new ArrayList();
-    list.addAll(expression.getUsedVariable());
-    list.addAll(statement.getUsedVariable());
-    return list;
+  public void getUsedVariable(final List list) {
+    expression.getUsedVariable(list);
+    statement.getUsedVariable(list);
   }
 }