The methods to get variables do not instantiate ArrayList each time, only one is...

[phpeclipse.git] / net.sourceforge.phpeclipse / src / net / sourceforge / phpdt / internal / compiler / ast / FunctionCall.java

diff --git a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/FunctionCall.java b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/FunctionCall.java
index 6e270c7..1d1e4c8 100644 (file)
--- a/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/FunctionCall.java
+++ b/net.sourceforge.phpeclipse/src/net/sourceforge/phpdt/internal/compiler/ast/FunctionCall.java
@@ -45,38 +45,30 @@ public class FunctionCall extends AbstractSuffixExpression {
 
   /**
    * Get the variables from outside (parameters, globals ...)
-   * @return the variables from outside
    */
-  public List getOutsideVariable() {
-    return new ArrayList(1);
+  public void getOutsideVariable(final List list) {
   }
 
   /**
    * get the modified variables.
-   * @return the variables from we change value
    */
-  public List getModifiedVariable() {
-    if (args == null) {
-      return new ArrayList(1);
-    }
-    final ArrayList list = new ArrayList();
-    for (int i = 0; i < args.length; i++) {
-      list.addAll(args[i].getModifiedVariable());
+  public void getModifiedVariable(final List list) {
+    if (args != null) {
+      for (int i = 0; i < args.length; i++) {
+        args[i].getModifiedVariable(list);
+      }
     }
-    return list;
   }
 
   /**
    * Get the variables used.
-   * @return the variables used
    */
-  public List getUsedVariable() {
-    final List list = functionName.getUsedVariable();
+  public void getUsedVariable(final List list) {
+    functionName.getUsedVariable(list);
     if (args != null) {
       for (int i = 0; i < args.length; i++) {
-        list.addAll(args[i].getUsedVariable());
+        args[i].getUsedVariable(list);
       }
     }
-    return list;
   }
 }