X-Git-Url: http://git.phpeclipse.com

diff --git a/net.sourceforge.phpeclipse/src/test/PHPParser.jj b/net.sourceforge.phpeclipse/src/test/PHPParser.jj
index a6bce7c..e3b05cf 100644
--- a/net.sourceforge.phpeclipse/src/test/PHPParser.jj
+++ b/net.sourceforge.phpeclipse/src/test/PHPParser.jj
@@ -38,6 +38,8 @@ import net.sourceforge.phpdt.internal.compiler.parser.PHPOutlineInfo;
 import net.sourceforge.phpdt.internal.compiler.parser.PHPSegmentWithChildren;
 import net.sourceforge.phpdt.internal.compiler.parser.PHPFunctionDeclaration;
 import net.sourceforge.phpdt.internal.compiler.parser.PHPClassDeclaration;
+import net.sourceforge.phpdt.internal.compiler.parser.PHPVarDeclaration;
+import net.sourceforge.phpdt.internal.compiler.parser.PHPReqIncDeclaration;
 
 /**
  * A new php parser.
@@ -46,7 +48,7 @@ import net.sourceforge.phpdt.internal.compiler.parser.PHPClassDeclaration;
  * You can test the parser with the PHPParserTestCase2.java
  * @author Matthieu Casanova
  */
-public class PHPParser extends PHPParserSuperclass {
+public final class PHPParser extends PHPParserSuperclass {
 
   private static IFile fileToParse;
 
@@ -55,9 +57,6 @@ public class PHPParser extends PHPParserSuperclass {
 
   private static final String PARSE_ERROR_STRING = "Parse error"; //$NON-NLS-1$
   private static final String PARSE_WARNING_STRING = "Warning"; //$NON-NLS-1$
-  public static final int ERROR = 2;
-  public static final int WARNING = 1;
-  public static final int INFO = 0;
   PHPOutlineInfo outlineInfo;
   private static int errorLevel = ERROR;
   private static String errorMessage;
@@ -65,7 +64,7 @@ public class PHPParser extends PHPParserSuperclass {
   public PHPParser() {
   }
 
-  public void setFileToParse(IFile fileToParse) {
+  public final void setFileToParse(IFile fileToParse) {
     this.fileToParse = fileToParse;
   }
 
@@ -74,7 +73,7 @@ public class PHPParser extends PHPParserSuperclass {
     this.fileToParse = fileToParse;
   }
 
-  public void phpParserTester(String strEval) throws CoreException, ParseException {
+  public static final void phpParserTester(String strEval) throws CoreException, ParseException {
     PHPParserTokenManager.SwitchTo(PHPParserTokenManager.PHPPARSING);
     StringReader stream = new StringReader(strEval);
     if (jj_input_stream == null) {
@@ -84,7 +83,7 @@ public class PHPParser extends PHPParserSuperclass {
     phpTest();
   }
 
-  public void htmlParserTester(String strEval) throws CoreException, ParseException {
+  public static final void htmlParserTester(String strEval) throws CoreException, ParseException {
     StringReader stream = new StringReader(strEval);
     if (jj_input_stream == null) {
       jj_input_stream = new SimpleCharStream(stream, 1, 1);
@@ -93,7 +92,7 @@ public class PHPParser extends PHPParserSuperclass {
     phpFile();
   }
 
-  public PHPOutlineInfo parseInfo(Object parent, String s) {
+  public final PHPOutlineInfo parseInfo(Object parent, String s) {
     outlineInfo = new PHPOutlineInfo(parent);
     currentSegment = outlineInfo.getDeclarations();
     StringReader stream = new StringReader(s);
@@ -104,45 +103,38 @@ public class PHPParser extends PHPParserSuperclass {
     try {
       parse();
     } catch (ParseException e) {
-      if (errorMessage == null) {
-        PHPeclipsePlugin.log(e);
-      } else {
-        setMarker(errorMessage, e.currentToken.beginLine, errorLevel);
-        errorMessage = null;
-      }
+      processParseException(e);
     }
     return outlineInfo;
   }
 
-
   /**
-   * Create marker for the parse error
+   * This method will process the parse exception.
+   * If the error message is null, the parse exception wasn't catched and a trace is written in the log
+   * @param e the ParseException
    */
-  private static void setMarker(String message, int lineNumber, int errorLevel) {
-    try {
-      setMarker(fileToParse, message, lineNumber, errorLevel);
-    } catch (CoreException e) {
+  private static void processParseException(final ParseException e) {
+    if (errorMessage == null) {
       PHPeclipsePlugin.log(e);
+      errorMessage = "this exception wasn't handled by the parser please tell us how to reproduce it";
     }
+    setMarker(e);
+    errorMessage = null;
   }
 
-  public static void setMarker(IFile file, String message, int lineNumber, int errorLevel) throws CoreException {
-    if (file != null) {
-      Hashtable attributes = new Hashtable();
-      MarkerUtilities.setMessage(attributes, message);
-      switch (errorLevel) {
-        case ERROR :
-          attributes.put(IMarker.SEVERITY, new Integer(IMarker.SEVERITY_ERROR));
-          break;
-        case WARNING :
-          attributes.put(IMarker.SEVERITY, new Integer(IMarker.SEVERITY_WARNING));
-          break;
-        case INFO :
-          attributes.put(IMarker.SEVERITY, new Integer(IMarker.SEVERITY_INFO));
-          break;
-      }
-      MarkerUtilities.setLineNumber(attributes, lineNumber);
-      MarkerUtilities.createMarker(file, attributes, IMarker.PROBLEM);
+  /**
+   * Create marker for the parse error
+   */
+  private static void setMarker(ParseException e) {
+    try {
+      setMarker(fileToParse,
+                errorMessage,
+                jj_input_stream.tokenBegin,
+                jj_input_stream.tokenBegin + e.currentToken.image.length(),
+                errorLevel,
+                "Line " + e.currentToken.beginLine);
+    } catch (CoreException e2) {
+      PHPeclipsePlugin.log(e2);
     }
   }
 
@@ -209,17 +201,16 @@ public class PHPParser extends PHPParserSuperclass {
     }
   }
 
-  public void parse(String s) throws CoreException {
-    ReInit(new StringReader(s));
+  public final void parse(String s) throws CoreException {
+    StringReader stream = new StringReader(s);
+    if (jj_input_stream == null) {
+      jj_input_stream = new SimpleCharStream(stream, 1, 1);
+    }
+    ReInit(stream);
     try {
       parse();
     } catch (ParseException e) {
-      if (errorMessage == null) {
-        PHPeclipsePlugin.log(e);
-      } else {
-        setMarker(errorMessage, e.currentToken.beginLine, errorLevel);
-        errorMessage = null;
-      }
+      processParseException(e);
     }
   }
 
@@ -245,7 +236,7 @@ public class PHPParser extends PHPParserSuperclass {
     }
   }
 
-  public void parse() throws ParseException {
+  public static final void parse() throws ParseException {
 	  phpFile();
   }
 }
@@ -290,10 +281,14 @@ PARSER_END(PHPParser)
   "/*" : IN_MULTI_LINE_COMMENT
 }
 
-<IN_SINGLE_LINE_COMMENT>
-SPECIAL_TOKEN :
+<IN_SINGLE_LINE_COMMENT> SPECIAL_TOKEN :
+{
+  <SINGLE_LINE_COMMENT: "\n" | "\r" | "\r\n" > : PHPPARSING
+}
+
+<IN_SINGLE_LINE_COMMENT> TOKEN :
 {
-  <SINGLE_LINE_COMMENT: "\n" | "\r" | "\r\n" | "?>" > : PHPPARSING
+  <SINGLE_LINE_COMMENT_PHPEND : "?>" > : DEFAULT
 }
 
 <IN_FORMAL_COMMENT>
@@ -365,6 +360,10 @@ MORE :
 | < TRUE: "true" >
 | < WHILE: "while" >
 | < ENDWHILE : "endwhile" >
+| <ENDIF : "endif" >
+| <ENDFOR : "endfor" >
+| <FOREACH : "foreach" >
+| <AS : "as" >
 }
 
 /* TYPES */
@@ -416,20 +415,30 @@ MORE :
   < STRING_LITERAL: (<STRING_1> | <STRING_2> | <STRING_3>)>
 |    < STRING_1:
       "\""
-      (   (~["\""])
-        | "\\\""
+      (
+        ~["\""]
+        |
+        "\\\""
       )*
       "\""
     >
 |    < STRING_2:
       "'"
-      (   (~["'"]))*
+      (
+      ~["'"]
+       |
+       "\\'"
+      )*
 
       "'"
     >
 |   < STRING_3:
       "`"
-      (   (~["`"]))*
+      (
+        ~["`"]
+      |
+        "\\`"
+      )*
       "`"
     >
 }
@@ -449,7 +458,7 @@ MORE :
   >
 |
   < #SPECIAL:
-    "_"
+    "_" | ["\u007f"-"\u00ff"]
   >
 }
 
@@ -474,43 +483,46 @@ MORE :
 {
   <AT     : "@">
 | <DOLLAR : "$">
-| < ASSIGN: "=" >
-| < GT: ">" >
-| < LT: "<" >
-| < BANG: "!" >
-| < HOOK: "?" >
-| < COLON: ":" >
-| < EQ: "==" >
-| < LE: "<=" >
-| < GE: ">=" >
-| < NE: "!=" >
-| < SC_OR: "||" >
-| < SC_AND: "&&" >
-| < INCR: "++" >
-| < DECR: "--" >
-| < PLUS: "+" >
-| < MINUS: "-" >
-| < STAR: "*" >
-| < SLASH: "/" >
-| < BIT_AND: "&" >
-| < BIT_OR: "|" >
-| < XOR: "^" >
-| < REM: "%" >
-| < LSHIFT: "<<" >
-| < RSIGNEDSHIFT: ">>" >
-| < RUNSIGNEDSHIFT: ">>>" >
-| < PLUSASSIGN: "+=" >
-| < MINUSASSIGN: "-=" >
-| < STARASSIGN: "*=" >
-| < SLASHASSIGN: "/=" >
-| < ANDASSIGN: "&=" >
-| < ORASSIGN: "|=" >
-| < XORASSIGN: "^=" >
-| < DOTASSIGN: ".=" >
-| < REMASSIGN: "%=" >
-| < LSHIFTASSIGN: "<<=" >
-| < RSIGNEDSHIFTASSIGN: ">>=" >
-| < RUNSIGNEDSHIFTASSIGN: ">>>=" >
+| <ASSIGN: "=" >
+| <GT: ">" >
+| <LT: "<" >
+| <BANG: "!" >
+| <HOOK: "?" >
+| <COLON: ":" >
+| <EQ: "==" >
+| <LE: "<=" >
+| <GE: ">=" >
+| <NE: "!=" >
+| <DIF: "<>" >
+| <SC_OR: "||" >
+| <SC_AND: "&&" >
+| <INCR: "++" >
+| <DECR: "--" >
+| <PLUS: "+" >
+| <MINUS: "-" >
+| <STAR: "*" >
+| <SLASH: "/" >
+| <BIT_AND: "&" >
+| <BIT_OR: "|" >
+| <XOR: "^" >
+| <REM: "%" >
+| <LSHIFT: "<<" >
+| <RSIGNEDSHIFT: ">>" >
+| <RUNSIGNEDSHIFT: ">>>" >
+| <PLUSASSIGN: "+=" >
+| <MINUSASSIGN: "-=" >
+| <STARASSIGN: "*=" >
+| <SLASHASSIGN: "/=" >
+| <ANDASSIGN: "&=" >
+| <ORASSIGN: "|=" >
+| <XORASSIGN: "^=" >
+| <DOTASSIGN: ".=" >
+| <REMASSIGN: "%=" >
+| <LSHIFTASSIGN: "<<=" >
+| <RSIGNEDSHIFTASSIGN: ">>=" >
+| <BANGDOUBLEEQUAL: "!==" >
+| <TRIPLEEQUAL: "===" >
+| <TILDEEQUAL: "~=" >
 }
 
 <PHPPARSING> TOKEN :
@@ -536,8 +548,22 @@ void phpTest() :
 void phpFile() :
 {}
 {
-  (<PHPSTART> Php() <PHPEND>)*
+  try {
+  (<PHPSTART> Php()
+  try {
+    <PHPEND>
+  } catch (ParseException e) {
+    errorMessage = "'?>' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
+    )*
   <EOF>
+  } catch (TokenMgrError e) {
+    errorMessage = e.getMessage();
+    errorLevel   = ERROR;
+    throw generateParseException();
+  }
 }
 
 void Php() :
@@ -550,25 +576,43 @@ void ClassDeclaration() :
 {
   PHPClassDeclaration classDeclaration;
   Token className;
-  int pos = jj_input_stream.bufpos;
+  final int pos = jj_input_stream.bufpos;
 }
 {
   <CLASS> className = <IDENTIFIER> [ <EXTENDS> <IDENTIFIER> ]
   {
-    classDeclaration = new PHPClassDeclaration(currentSegment,className.image,pos);
-    currentSegment.add(classDeclaration);
-    currentSegment = classDeclaration;
+    if (currentSegment != null) {
+      classDeclaration = new PHPClassDeclaration(currentSegment,className.image,pos);
+      currentSegment.add(classDeclaration);
+      currentSegment = classDeclaration;
+    }
   }
   ClassBody()
   {
-    currentSegment = (PHPSegmentWithChildren) currentSegment.getParent();
+    if (currentSegment != null) {
+      currentSegment = (PHPSegmentWithChildren) currentSegment.getParent();
+    }
   }
 }
 
 void ClassBody() :
 {}
 {
-  <LBRACE> ( ClassBodyDeclaration() )* <RBRACE>
+  try {
+    <LBRACE>
+  } catch (ParseException e) {
+    errorMessage = "'{' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
+  ( ClassBodyDeclaration() )*
+  try {
+    <RBRACE>
+  } catch (ParseException e) {
+    errorMessage = "'var', 'function' or '}' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
 }
 
 void ClassBodyDeclaration() :
@@ -580,37 +624,77 @@ void ClassBodyDeclaration() :
 }
 
 void FieldDeclaration() :
-{}
 {
-  <VAR> VariableDeclarator() ( <COMMA> VariableDeclarator() )* <SEMICOLON>
+  PHPVarDeclaration variableDeclaration;
+}
+{
+  <VAR> variableDeclaration = VariableDeclarator()
+  {
+    if (currentSegment != null) {
+      currentSegment.add(variableDeclaration);
+    }
+  }
+  ( <COMMA>
+      variableDeclaration = VariableDeclarator()
+      {
+      if (currentSegment != null) {
+        currentSegment.add(variableDeclaration);
+      }
+      }
+  )*
+  try {
+    <SEMICOLON>
+  } catch (ParseException e) {
+    errorMessage = "';' expected after variable declaration";
+    errorLevel   = ERROR;
+    throw e;
+  }
 }
 
-String VariableDeclarator() :
+PHPVarDeclaration VariableDeclarator() :
 {
-  String expr;
-  StringBuffer buff = new StringBuffer();
+  String varName;
+  String varValue = null;
+  final int pos = jj_input_stream.bufpos;
 }
 {
-  expr = VariableDeclaratorId()
-  {buff.append(expr);}
-  [ <ASSIGN> expr = VariableInitializer()
-    {buff.append("=").append(expr);}
+  varName = VariableDeclaratorId()
+  [
+    <ASSIGN>
+    try {
+      varValue = VariableInitializer()
+    } catch (ParseException e) {
+      errorMessage = "Literal expression expected in variable initializer";
+      errorLevel   = ERROR;
+      throw e;
+    }
   ]
-  {return buff.toString();}
+  {
+    if (varValue == null) {
+      return new PHPVarDeclaration(currentSegment,varName,pos);
+    }
+    return new PHPVarDeclaration(currentSegment,varName,pos,varValue);
+  }
 }
 
 String VariableDeclaratorId() :
 {
   String expr;
-  StringBuffer buff = new StringBuffer();
+  final StringBuffer buff = new StringBuffer();
 }
 {
-  expr = Variable()
-  {buff.append(expr);}
-  ( LOOKAHEAD(2) expr = VariableSuffix()
-  {buff.append(expr);}
-  )*
-  {return buff.toString();}
+  try {
+    expr = Variable()
+    {buff.append(expr);}
+    ( LOOKAHEAD(2) expr = VariableSuffix()
+    {buff.append(expr);}
+    )*
+    {return buff.toString();}
+  } catch (ParseException e) {
+    errorMessage = "'$' expected for variable identifier";
+    errorLevel   = ERROR;
+    throw e;
+  }
 }
 
 String Variable():
@@ -646,24 +730,46 @@ Token token;
       return token.image;
     }
     return token + "{" + expr + "}";
-  }|
+  }
+|
   <DOLLAR> expr = VariableName()
   {return "$" + expr;}
+|
+  token = <DOLLAR_ID> [expr = VariableName()]
+  {
+  if (expr == null) {
+    return token.image;
+  }
+  return token.image + expr;
+  }
 }
 
 String VariableInitializer() :
 {
   String expr;
+  Token token;
 }
 {
-  expr = Expression()
+  expr = Literal()
+  {return expr;}
+|
+  <MINUS> (token = <INTEGER_LITERAL> | token = <FLOATING_POINT_LITERAL>)
+  {return "-" + token.image;}
+|
+  <PLUS> (token = <INTEGER_LITERAL> | token = <FLOATING_POINT_LITERAL>)
+  {return "+" + token.image;}
+|
+  expr = ArrayDeclarator()
   {return expr;}
+|
+  token = <IDENTIFIER>
+  {return token.image;}
 }
 
 String ArrayVariable() :
 {
 String expr;
-StringBuffer buff = new StringBuffer();
+final StringBuffer buff = new StringBuffer();
 }
 {
   expr = Expression()
@@ -676,7 +782,7 @@ StringBuffer buff = new StringBuffer();
 String ArrayInitializer() :
 {
 String expr = null;
-StringBuffer buff = new StringBuffer("(");
+final StringBuffer buff = new StringBuffer("(");
 }
 {
   <LPAREN> [ expr = ArrayVariable()
@@ -698,12 +804,16 @@ void MethodDeclaration() :
 {
   <FUNCTION> functionDeclaration = MethodDeclarator()
   {
-    currentSegment.add(functionDeclaration);
-    currentSegment = functionDeclaration;
+    if (currentSegment != null) {
+      currentSegment.add(functionDeclaration);
+      currentSegment = functionDeclaration;
+    }
   }
-  ( Block() | <SEMICOLON> )
+  Block()
   {
-    currentSegment = (PHPSegmentWithChildren) currentSegment.getParent();
+    if (currentSegment != null) {
+      currentSegment = (PHPSegmentWithChildren) currentSegment.getParent();
+    }
   }
 }
 
@@ -712,13 +822,15 @@ PHPFunctionDeclaration MethodDeclarator() :
   Token identifier;
   StringBuffer methodDeclaration = new StringBuffer();
   String formalParameters;
-  int pos = jj_input_stream.bufpos;
+  final int pos = jj_input_stream.bufpos;
 }
 {
-  [ <BIT_AND> {methodDeclaration.append("&");}]
-  identifier = <IDENTIFIER> formalParameters = FormalParameters()
+  [ <BIT_AND> {methodDeclaration.append("&");} ]
+  identifier = <IDENTIFIER>
+  {methodDeclaration.append(identifier);}
+    formalParameters = FormalParameters()
   {
-    methodDeclaration.append(identifier).append(formalParameters);
+    methodDeclaration.append(formalParameters);
     return new PHPFunctionDeclaration(currentSegment,methodDeclaration.toString(),pos);
   }
 }
@@ -726,13 +838,30 @@ PHPFunctionDeclaration MethodDeclarator() :
 String FormalParameters() :
 {
   String expr;
-  StringBuffer buff = new StringBuffer("(");
+  final StringBuffer buff = new StringBuffer("(");
 }
 {
-  <LPAREN> [ expr = FormalParameter() {buff.append(expr);}
-            ( <COMMA> expr = FormalParameter()
-            {buff.append(",").append(expr);}
-            )* ] <RPAREN>
+  try {
+  <LPAREN>
+  } catch (ParseException e) {
+    errorMessage = "Formal parameter expected after function identifier";
+    errorLevel   = ERROR;
+    jj_consume_token(token.kind);
+  }
+            [ expr = FormalParameter()
+              {buff.append(expr);}
+            (
+                <COMMA> expr = FormalParameter()
+                {buff.append(",").append(expr);}
+            )*
+            ]
+  try {
+    <RPAREN>
+  } catch (ParseException e) {
+    errorMessage = "')' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
  {
   buff.append(")");
   return buff.toString();
@@ -741,13 +870,13 @@ String FormalParameters() :
 
 String FormalParameter() :
 {
-  String expr;
-  StringBuffer buff = new StringBuffer();
+  PHPVarDeclaration variableDeclaration;
+  final StringBuffer buff = new StringBuffer();
 }
 {
-  [<BIT_AND> {buff.append("&");}] expr = VariableDeclarator()
+  [<BIT_AND> {buff.append("&");}] variableDeclaration = VariableDeclarator()
   {
-    buff.append(expr);
+    buff.append(variableDeclaration.toString());
     return buff.toString();
   }
 }
@@ -778,6 +907,9 @@ String Type() :
 |
   <INTEGER>
   {return "integer";}
+|
+  <OBJECT>
+  {return "object";}
 }
 
 String Expression() :
@@ -793,7 +925,13 @@ String Expression() :
   expr = ConditionalExpression()
   [
     assignOperator = AssignmentOperator()
-    expr2 = Expression()
+    try {
+      expr2 = Expression()
+    } catch (ParseException e) {
+      errorMessage = "expression expected";
+      errorLevel   = ERROR;
+      throw e;
+    }
   ]
   {
     if (expr2 == null) {
@@ -805,9 +943,7 @@ String Expression() :
 }
 
 String AssignmentOperator() :
-{
-  Token assignOperator;
-}
+{}
 {
   <ASSIGN>
 {return "=";}
@@ -825,8 +961,6 @@ String AssignmentOperator() :
 {return "<<=";}
 | <RSIGNEDSHIFTASSIGN>
 {return ">>=";}
-| <RUNSIGNEDSHIFTASSIGN>
-{return ">>>=";}
 | <ANDASSIGN>
 {return "&=";}
 | <XORASSIGN>
@@ -835,6 +969,8 @@ String AssignmentOperator() :
 {return "|=";}
 | <DOTASSIGN>
 {return ".=";}
+| <TILDEEQUAL>
+{return "~=";}
 }
 
 String ConditionalExpression() :
@@ -859,7 +995,7 @@ String ConditionalOrExpression() :
   String expr;
   Token operator;
   String expr2 = null;
-  StringBuffer buff = new StringBuffer();
+  final StringBuffer buff = new StringBuffer();
 }
 {
   expr = ConditionalAndExpression()
@@ -883,7 +1019,7 @@ String ConditionalAndExpression() :
   String expr;
   Token operator;
   String expr2 = null;
-  StringBuffer buff = new StringBuffer();
+  final StringBuffer buff = new StringBuffer();
 }
 {
   expr = ConcatExpression()
@@ -906,7 +1042,7 @@ String ConcatExpression() :
 {
   String expr;
   String expr2 = null;
-  StringBuffer buff = new StringBuffer();
+  final StringBuffer buff = new StringBuffer();
 }
 {
   expr = InclusiveOrExpression()
@@ -929,7 +1065,7 @@ String InclusiveOrExpression() :
 {
   String expr;
   String expr2 = null;
-  StringBuffer buff = new StringBuffer();
+  final StringBuffer buff = new StringBuffer();
 }
 {
   expr = ExclusiveOrExpression()
@@ -952,7 +1088,7 @@ String ExclusiveOrExpression() :
 {
   String expr;
   String expr2 = null;
-  StringBuffer buff = new StringBuffer();
+  final StringBuffer buff = new StringBuffer();
 }
 {
   expr = AndExpression()
@@ -973,9 +1109,9 @@ String ExclusiveOrExpression() :
 
 String AndExpression() :
 {
-  String expr;
+  final String expr;
   String expr2 = null;
-  StringBuffer buff = new StringBuffer();
+  final StringBuffer buff = new StringBuffer();
 }
 {
   expr = EqualityExpression()
@@ -999,13 +1135,19 @@ String EqualityExpression() :
   String expr;
   Token operator;
   String expr2;
-  StringBuffer buff = new StringBuffer();
+  final StringBuffer buff = new StringBuffer();
 }
 {
   expr = RelationalExpression()
   {buff.append(expr);}
   (
-  ( operator = <EQ> | operator = <NE> ) expr2 = RelationalExpression()
+  (   operator = <EQ>
+    | operator = <DIF>
+    | operator = <NE>
+    | operator = <BANGDOUBLEEQUAL>
+    | operator = <TRIPLEEQUAL>
+  )
+  expr2 = RelationalExpression()
   {
     buff.append(operator.image);
     buff.append(expr2);
@@ -1019,7 +1161,7 @@ String RelationalExpression() :
   String expr;
   Token operator;
   String expr2;
-  StringBuffer buff = new StringBuffer();
+  final StringBuffer buff = new StringBuffer();
 }
 {
   expr = ShiftExpression()
@@ -1038,17 +1180,16 @@ String ShiftExpression() :
 {
   String expr;
   Token operator;
-  String expr2;
-  StringBuffer buff = new StringBuffer();
+  final StringBuffer buff = new StringBuffer();
 }
 {
   expr = AdditiveExpression()
   {buff.append(expr);}
   (
-  (operator = <LSHIFT> | operator = <RSIGNEDSHIFT> | operator = <RUNSIGNEDSHIFT> ) expr2 = AdditiveExpression()
+  (operator = <LSHIFT> | operator = <RSIGNEDSHIFT> | operator = <RUNSIGNEDSHIFT> ) expr = AdditiveExpression()
   {
     buff.append(operator.image);
-    buff.append(expr2);
+    buff.append(expr);
   }
   )*
   {return buff.toString();}
@@ -1058,17 +1199,16 @@ String AdditiveExpression() :
 {
   String expr;
   Token operator;
-  String expr2;
-  StringBuffer buff = new StringBuffer();
+  final StringBuffer buff = new StringBuffer();
 }
 {
   expr = MultiplicativeExpression()
   {buff.append(expr);}
   (
-   ( operator = <PLUS> | operator = <MINUS> ) expr2 = MultiplicativeExpression()
+   ( operator = <PLUS> | operator = <MINUS> ) expr = MultiplicativeExpression()
   {
     buff.append(operator.image);
-    buff.append(expr2);
+    buff.append(expr);
   }
    )*
   {return buff.toString();}
@@ -1078,34 +1218,51 @@ String MultiplicativeExpression() :
 {
   String expr;
   Token operator;
-  String expr2;
-  StringBuffer buff = new StringBuffer();}
+  final StringBuffer buff = new StringBuffer();}
 {
   expr = UnaryExpression()
   {buff.append(expr);}
   (
-  ( operator = <STAR> | operator = <SLASH> | operator = <REM> ) expr2 = UnaryExpression()
+  ( operator = <STAR> | operator = <SLASH> | operator = <REM> ) expr = UnaryExpression()
   {
     buff.append(operator.image);
-    buff.append(expr2);
+    buff.append(expr);
   }
   )*
   {return buff.toString();}
 }
 
+/**
+ * An unary expression starting with @, & or nothing
+ */
 String UnaryExpression() :
 {
   String expr;
-  StringBuffer buff = new StringBuffer();
+  Token token;
+  final StringBuffer buff = new StringBuffer();
 }
 {
-  <AT> expr = UnaryExpression()
-  {return "@" + expr;}
+  token = <BIT_AND> expr = UnaryExpressionNoPrefix()
+  {
+    if (token == null) {
+      return expr;
+    }
+    return token.image + expr;
+  }
 |
-  ( <PLUS> {buff.append("+");}| <MINUS> {buff.append("-");}) expr = UnaryExpression()
+  (<AT> {buff.append("@");})* expr = UnaryExpressionNoPrefix()
+  {return buff.append(expr).toString();}
+}
+
+String UnaryExpressionNoPrefix() :
+{
+  String expr;
+  Token token;
+}
+{
+  ( token = <PLUS> | token = <MINUS> ) expr = UnaryExpression()
   {
-    buff.append(expr);
-    return buff.toString();
+    return token.image + expr;
   }
 |
   expr = PreIncrementExpression()
@@ -1115,9 +1272,10 @@ String UnaryExpression() :
   {return expr;}
 |
   expr = UnaryExpressionNotPlusMinus()
-  {return buff.toString();}
+  {return expr;}
 }
 
+
 String PreIncrementExpression() :
 {
 String expr;
@@ -1160,8 +1318,7 @@ String UnaryExpressionNotPlusMinus() :
 
 String CastExpression() :
 {
-String type;
-String expr;
+final String type, expr;
 }
 {
   <LPAREN> type = Type() <RPAREN> expr = UnaryExpression()
@@ -1187,7 +1344,7 @@ String PrimaryExpression() :
 {
   Token identifier;
   String expr;
-  StringBuffer buff = new StringBuffer();
+  final StringBuffer buff = new StringBuffer();
 }
 {
   LOOKAHEAD(2)
@@ -1199,14 +1356,19 @@ String PrimaryExpression() :
   )*
   {return buff.toString();}
 |
-  expr = PrimaryPrefix()
-  {buff.append(expr);}
-  (
-  expr = PrimarySuffix()
-  {buff.append(expr);}
-  )*
+  expr = PrimaryPrefix()  {buff.append(expr);}
+  ( expr = PrimarySuffix()  {buff.append(expr);} )*
   {return buff.toString();}
 |
+  expr = ArrayDeclarator()
+  {return "array" + expr;}
+}
+
+String ArrayDeclarator() :
+{
+  final String expr;
+}
+{
   <ARRAY> expr = ArrayInitializer()
   {return "array" + expr;}
 }
@@ -1220,11 +1382,8 @@ String PrimaryPrefix() :
   token = <IDENTIFIER>
   {return token.image;}
 |
-  [token = <BIT_AND>] <NEW> expr = ClassIdentifier()
+  <NEW> expr = ClassIdentifier()
   {
-    if (token == null) {
-      return "new " + expr;
-    }
     return "new " + expr;
   }
 |  
@@ -1265,7 +1424,14 @@ String VariableSuffix() :
   <CLASSACCESS> expr = VariableName()
   {return "->" + expr;}
 | 
-  <LBRACKET> [ expr = Expression() ] <RBRACKET>
+  <LBRACKET> [ expr = Expression() ]
+  try {
+    <RBRACKET>
+  } catch (ParseException e) {
+    errorMessage = "']' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
   {
     if(expr == null) {
       return "[]";
@@ -1286,14 +1452,8 @@ String Literal() :
   token = <FLOATING_POINT_LITERAL>
   {return token.image;}
 |
-  try {
-    token = <STRING_LITERAL>
+  token = <STRING_LITERAL>
   {return token.image;}
-  } catch (TokenMgrError e) {
-    errorMessage = "unterminated string";
-    errorLevel   = ERROR;
-    throw generateParseException();
-  }
 |
   expr = BooleanLiteral()
   {return expr;}
@@ -1343,7 +1503,7 @@ String expr = null;
 String ArgumentList() :
 {
 String expr;
-StringBuffer buff = new StringBuffer();
+final StringBuffer buff = new StringBuffer();
 }
 {
   expr = Expression()
@@ -1371,7 +1531,14 @@ void Statement() :
 {}
 {
   LOOKAHEAD(2)
-  Expression()  (<SEMICOLON> | "?>")
+  Expression()
+  try {
+    (<SEMICOLON> | "?>")
+  } catch (ParseException e) {
+    errorMessage = "';' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
 |
   LOOKAHEAD(2)
   LabeledStatement()
@@ -1399,6 +1566,8 @@ void Statement() :
 |
   ForStatement()
 |
+  ForeachStatement()
+|
   BreakStatement()
 |
   ContinueStatement()
@@ -1407,7 +1576,7 @@ void Statement() :
 |
   EchoStatement()
 |
-  IncludeStatement()
+  [<AT>] IncludeStatement()
 |
   StaticStatement()
 |
@@ -1415,20 +1584,75 @@ void Statement() :
 }
 
 void IncludeStatement() :
-{}
 {
-  <REQUIRE> Expression() (<SEMICOLON> | "?>")
+  String expr;
+  final int pos = jj_input_stream.bufpos;
+}
+{
+  <REQUIRE>
+  expr = Expression()
+  {
+    if (currentSegment != null) {
+      currentSegment.add(new PHPReqIncDeclaration(currentSegment, "require",pos,expr));
+    }
+  }
+  try {
+    (<SEMICOLON> | "?>")
+  } catch (ParseException e) {
+    errorMessage = "';' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
 |
-  <REQUIRE_ONCE> Expression() (<SEMICOLON> | "?>")
+  <REQUIRE_ONCE>
+  expr = Expression()
+  {
+    if (currentSegment != null) {
+      currentSegment.add(new PHPReqIncDeclaration(currentSegment, "require_once",pos,expr));
+    }
+  }
+  try {
+    (<SEMICOLON> | "?>")
+  } catch (ParseException e) {
+    errorMessage = "';' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
 |
-  <INCLUDE> Expression() (<SEMICOLON> | "?>")
+  <INCLUDE>
+  expr = Expression()
+  {
+    if (currentSegment != null) {
+      currentSegment.add(new PHPReqIncDeclaration(currentSegment, "include",pos,expr));
+    }
+  }
+  try {
+    (<SEMICOLON> | "?>")
+  } catch (ParseException e) {
+    errorMessage = "';' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
 |
-  <INCLUDE_ONCE> Expression() (<SEMICOLON> | "?>")
+  <INCLUDE_ONCE>
+  expr = Expression()
+  {
+    if (currentSegment != null) {
+      currentSegment.add(new PHPReqIncDeclaration(currentSegment, "include_once",pos,expr));
+    }
+  }
+  try {
+    (<SEMICOLON> | "?>")
+  } catch (ParseException e) {
+    errorMessage = "';' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
 }
 
 String PrintExpression() :
 {
-  StringBuffer buff = new StringBuffer("print ");
+  final StringBuffer buff = new StringBuffer("print ");
   String expr;
 }
 {
@@ -1455,13 +1679,27 @@ void EchoStatement() :
 void GlobalStatement() :
 {}
 {
-  <GLOBAL> VariableDeclaratorId() (<COMMA> VariableDeclaratorId())* (<SEMICOLON> | "?>")
+  <GLOBAL> VariableDeclaratorId() (<COMMA> VariableDeclaratorId())*
+  try {
+    (<SEMICOLON> | "?>")
+  } catch (ParseException e) {
+    errorMessage = "';' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
 }
 
 void StaticStatement() :
 {}
 {
-  <STATIC> VariableDeclarator() (<COMMA> VariableDeclarator())* (<SEMICOLON> | "?>")
+  <STATIC> VariableDeclarator() (<COMMA> VariableDeclarator())*
+  try {
+    (<SEMICOLON> | "?>")
+  } catch (ParseException e) {
+    errorMessage = "';' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
 }
 
 void LabeledStatement() :
@@ -1473,7 +1711,15 @@ void LabeledStatement() :
 void Block() :
 {}
 {
-  <LBRACE> ( BlockStatement() )* <RBRACE>
+  try {
+    <LBRACE>
+  } catch (ParseException e) {
+    errorMessage = "'{' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
+  ( BlockStatement() )*
+  <RBRACE>
 }
 
 void BlockStatement() :
@@ -1499,11 +1745,6 @@ void EmptyStatement() :
 }
 
 void StatementExpression() :
-/*
- * The last expansion of this production accepts more than the legal
- * Java expansions for StatementExpression.  This expansion does not
- * use PostfixExpression for performance reasons.
- */
 {}
 {
   PreIncrementExpression()
@@ -1542,9 +1783,12 @@ void IfStatement() :
  * else's to the innermost if statement.  The LOOKAHEAD specification
  * is to tell JavaCC that we know what we are doing.
  */
-{}
 {
-  <IF> Condition("if") Statement() ( LOOKAHEAD(1) ElseIfStatement() )* [ LOOKAHEAD(1) <ELSE> Statement() ]
+  Token token;
+  final int pos = jj_input_stream.bufpos;
+}
+{
+  token = <IF> Condition("if") IfStatement0(pos,pos+token.image.length())
 }
 
 void Condition(String keyword) :
@@ -1567,6 +1811,52 @@ void Condition(String keyword) :
   }
 }
 
+void IfStatement0(int start,int end) :
+{
+}
+{
+  <COLON> (Statement())* (ElseIfStatementColon())* [ElseStatementColon()]
+
+  {try {
+  setMarker(fileToParse,
+            "Ugly syntax detected, you should if () {...} instead of if (): ... endif;",
+            start,
+            end,
+            INFO,
+            "Line " + token.beginLine);
+  } catch (CoreException e) {
+    PHPeclipsePlugin.log(e);
+  }}
+  try {
+    <ENDIF>
+  } catch (ParseException e) {
+    errorMessage = "'endif' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
+  try {
+    <SEMICOLON>
+  } catch (ParseException e) {
+    errorMessage = "';' expected 'endif' keyword";
+    errorLevel   = ERROR;
+    throw e;
+  }
+|
+  Statement() ( LOOKAHEAD(1) ElseIfStatement() )* [ LOOKAHEAD(1) <ELSE> Statement() ]
+}
+
+void ElseIfStatementColon() :
+{}
+{
+  <ELSEIF> Condition("elseif") <COLON> (Statement())*
+}
+
+void ElseStatementColon() :
+{}
+{
+  <ELSE> <COLON> (Statement())*
+}
+
 void ElseIfStatement() :
 {}
 {
@@ -1574,15 +1864,42 @@ void ElseIfStatement() :
 }
 
 void WhileStatement() :
-{}
 {
-  <WHILE> Condition("while") WhileStatement0()
+  Token token;
+  final int pos = jj_input_stream.bufpos;
+}
+{
+  token = <WHILE> Condition("while") WhileStatement0(pos,pos + token.image.length())
 }
 
-void WhileStatement0() :
+void WhileStatement0(final int start, final int end) :
 {}
 {
-  <COLON> (Statement())* <ENDWHILE> (<SEMICOLON> | "?>")
+  <COLON> (Statement())*
+  {try {
+  setMarker(fileToParse,
+            "Ugly syntax detected, you should while () {...} instead of while (): ... endwhile;",
+            start,
+            end,
+            INFO,
+            "Line " + token.beginLine);
+  } catch (CoreException e) {
+    PHPeclipsePlugin.log(e);
+  }}
+  try {
+    <ENDWHILE>
+  } catch (ParseException e) {
+    errorMessage = "'endwhile' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
+  try {
+    (<SEMICOLON> | "?>")
+  } catch (ParseException e) {
+    errorMessage = "';' expected after 'endwhile' keyword";
+    errorLevel   = ERROR;
+    throw e;
+  }
 |
   Statement()
 }
@@ -1590,13 +1907,112 @@ void WhileStatement0() :
 void DoStatement() :
 {}
 {
-  <DO> Statement() <WHILE> Condition("while") (<SEMICOLON> | "?>")
+  <DO> Statement() <WHILE> Condition("while")
+  try {
+    (<SEMICOLON> | "?>")
+  } catch (ParseException e) {
+    errorMessage = "';' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
 }
 
-void ForStatement() :
+void ForeachStatement() :
 {}
 {
-  <FOR> <LPAREN> [ ForInit() ] <SEMICOLON> [ Expression() ] <SEMICOLON> [ ForUpdate() ] <RPAREN> Statement()
+  <FOREACH>
+    try {
+    <LPAREN>
+  } catch (ParseException e) {
+    errorMessage = "'(' expected after 'foreach' keyword";
+    errorLevel   = ERROR;
+    throw e;
+  }
+  try {
+    Variable()
+  } catch (ParseException e) {
+    errorMessage = "variable expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
+  try {
+    <AS>
+  } catch (ParseException e) {
+    errorMessage = "'as' expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
+  try {
+    Variable()
+  } catch (ParseException e) {
+    errorMessage = "variable expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
+  [ <ARRAYASSIGN> Expression() ]
+  try {
+    <RPAREN>
+  } catch (ParseException e) {
+    errorMessage = "')' expected after 'foreach' keyword";
+    errorLevel   = ERROR;
+    throw e;
+  }
+  try {
+  Statement()
+  } catch (ParseException e) {
+    if (errorMessage != null) throw e;
+    errorMessage = "statement expected";
+    errorLevel   = ERROR;
+    throw e;
+  }
+}
+
+void ForStatement() :
+{
+Token token;
+final int pos = jj_input_stream.bufpos;
+}
+{
+  token = <FOR>
+  try {
+    <LPAREN>
+  } catch (ParseException e) {
+    errorMessage = "'(' expected after 'for' keyword";
+    errorLevel   = ERROR;
+    throw e;
+  }
+     [ ForInit() ] <SEMICOLON> [ Expression() ] <SEMICOLON> [ ForUpdate() ] <RPAREN>
+    (
+      Statement()
+    |
+      <COLON> (Statement())*
+      {
+        try {
+        setMarker(fileToParse,
+                  "Ugly syntax detected, you should for () {...} instead of for (): ... endfor;",
+                  pos,
+                  pos+token.image.length(),
+                  INFO,
+                  "Line " + token.beginLine);
+        } catch (CoreException e) {
+          PHPeclipsePlugin.log(e);
+        }
+      }
+      try {
+        <ENDFOR>
+      } catch (ParseException e) {
+        errorMessage = "'endfor' expected";
+        errorLevel   = ERROR;
+        throw e;
+      }
+      try {
+        <SEMICOLON>
+      } catch (ParseException e) {
+        errorMessage = "';' expected 'endfor' keyword";
+        errorLevel   = ERROR;
+        throw e;
+      }
+    )
 }
 
 void ForInit() :