From 7f1dada6b16f459947d264bdcca20db4f7ac8321 Mon Sep 17 00:00:00 2001 From: axelcl Date: Thu, 4 Nov 2004 21:02:20 +0000 Subject: [PATCH] Improved handling for right mouse click menu on file in Navigator: "Open PHP Browser" Now the action takes the current Browser from the Prefs "Browser Configuration" --- net.sourceforge.phpeclipse.webbrowser/build.xml | 104 ++++---- .../plugin.properties | 2 +- net.sourceforge.phpeclipse.webbrowser/plugin.xml | 2 +- .../phpeclipse/webbrowser/views/BrowserView.java | 10 +- net.sourceforge.phpeclipse/plugin.xml | 1 + .../phpeclipse/IPreferenceConstants.java | 4 +- .../phpeclipse/PHPEclipseBasePreferencePage.java | 267 ++++---------------- .../sourceforge/phpeclipse/PHPeclipsePlugin.java | 10 +- .../phpeclipse/actions/PHPEclipseShowAction.java | 160 ++++++------- 9 files changed, 188 insertions(+), 372 deletions(-) diff --git a/net.sourceforge.phpeclipse.webbrowser/build.xml b/net.sourceforge.phpeclipse.webbrowser/build.xml index da54a3e..9f0a91c 100644 --- a/net.sourceforge.phpeclipse.webbrowser/build.xml +++ b/net.sourceforge.phpeclipse.webbrowser/build.xml @@ -37,7 +37,7 @@ - + @@ -48,46 +48,46 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -118,11 +118,11 @@ - - + + - + @@ -131,23 +131,23 @@ - - - + + + - - + + - - + + @@ -170,7 +170,7 @@ - + diff --git a/net.sourceforge.phpeclipse.webbrowser/plugin.properties b/net.sourceforge.phpeclipse.webbrowser/plugin.properties index 6fd8fa2..87c6943 100644 --- a/net.sourceforge.phpeclipse.webbrowser/plugin.properties +++ b/net.sourceforge.phpeclipse.webbrowser/plugin.properties @@ -50,7 +50,7 @@ actionSetSwitchBrowser=Web Browser # Name of the preference pages preferenceInternetTitle=Internet preferenceInternetDescription=General internet settings are available in the contained preference pages. -preferenceWebBrowserTitle=Web Browser +preferenceWebBrowserTitle=Browser Configurations preferenceWebBrowserTitleLong=Installed Web Browsers preferenceWebBrowserDescription=Add, remove, or edit installed Web browsers.\nThe selected Web browser will be used whenever Web pages are opened. diff --git a/net.sourceforge.phpeclipse.webbrowser/plugin.xml b/net.sourceforge.phpeclipse.webbrowser/plugin.xml index 4b4a865..89f484f 100644 --- a/net.sourceforge.phpeclipse.webbrowser/plugin.xml +++ b/net.sourceforge.phpeclipse.webbrowser/plugin.xml @@ -55,7 +55,7 @@ diff --git a/net.sourceforge.phpeclipse.webbrowser/src/net/sourceforge/phpeclipse/webbrowser/views/BrowserView.java b/net.sourceforge.phpeclipse.webbrowser/src/net/sourceforge/phpeclipse/webbrowser/views/BrowserView.java index 4636163..5f13ca2 100644 --- a/net.sourceforge.phpeclipse.webbrowser/src/net/sourceforge/phpeclipse/webbrowser/views/BrowserView.java +++ b/net.sourceforge.phpeclipse.webbrowser/src/net/sourceforge/phpeclipse/webbrowser/views/BrowserView.java @@ -10,16 +10,10 @@ *******************************************************************************/ package net.sourceforge.phpeclipse.webbrowser.views; +import net.sourceforge.phpeclipse.webbrowser.internal.BrowserManager; import net.sourceforge.phpeclipse.webbrowser.internal.WebBrowser; import net.sourceforge.phpeclipse.webbrowser.internal.WebBrowserUtil; -import org.eclipse.core.resources.IWorkspaceRunnable; -import org.eclipse.core.resources.ResourcesPlugin; -import org.eclipse.core.runtime.CoreException; -import org.eclipse.core.runtime.IProgressMonitor; -import org.eclipse.core.runtime.IStatus; -import org.eclipse.core.runtime.Status; -import org.eclipse.core.runtime.jobs.Job; import org.eclipse.swt.browser.ProgressListener; import org.eclipse.swt.browser.StatusTextListener; import org.eclipse.swt.browser.TitleListener; @@ -46,7 +40,7 @@ public class BrowserView extends ViewPart { try { if (WebBrowserUtil.canUseInternalWebBrowser()) { instance = new WebBrowser(frame, true, true); - } + } } catch (Exception e) { instance = null; } diff --git a/net.sourceforge.phpeclipse/plugin.xml b/net.sourceforge.phpeclipse/plugin.xml index 3f94a4f..940c251 100644 --- a/net.sourceforge.phpeclipse/plugin.xml +++ b/net.sourceforge.phpeclipse/plugin.xml @@ -1172,6 +1172,7 @@ category="net.sourceforge.phpeclipse.ui.category.source" id="net.sourceforge.phpeclipse.phpeditor.toggle.comment"> +